Fix release CI

pierr3 · Feb 26, 2024 · 78300d1 · 78300d1
1 parent 4931d3b
commit 78300d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -19,9 +19,6 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - uses: actions/setup-python@v4
-        with:
-          python-version: "3.10"
       - name: Set env (release)
         if: github.event.release.prerelease == false
         run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
@@ -62,21 +59,19 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
-          python-version: "3.10"
+          python-version: "3.12"
       - name: Set env (release)
         if: github.event.release.prerelease == false
-        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $env:GITHUB_ENV
       - name: Set env (pre-release)
         if: github.event.release.prerelease == true
         run: |
           $ver = Get-Content .\VERSION_BETA -Raw
-          echo $ver
-          echo "RELEASE_VERSION=v$ver" >> $GITHUB_ENV
-          type VERSION_BETA > VERSION
-          type VERSION
-          echo ${{ env.RELEASE_VERSION }}
+          echo "Found beta release version: $ver"
+          echo "RELEASE_VERSION=v$ver" >> $env:GITHUB_ENV
+          cat VERSION_BETA > VERSION
       - name: Configure cmake
         run: |
           cmake -S . -B build/ -DVCPKG_BUILD_TYPE=${{ env.BUILD_TYPE }} -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DVCPKG_TARGET_TRIPLET=x64-windows
@@ -114,9 +109,9 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
-          python-version: "3.10"
+          python-version: "3.12"
       - name: Set env (release)
         if: github.event.release.prerelease == false
         run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

diff --git a/bundle_osx.sh b/bundle_osx.sh
@@ -43,5 +43,5 @@ cp -R resources/libafv_native.framework/ build/VectorAudio.app/Contents/Framewor
 
 xattr -cr build/VectorAudio.app
 if [ $# -eq 1 ]; then
-  codesign --timestamp -s "Developer ID Application" build/VectorAudio.app
+  codesign --deep --timestamp -s "Developer ID Application" build/VectorAudio.app
 fi