Pico 3.0 #54
Pico 3.0 #54
Conversation
|
Great initial draft, thanks Maya! ❤️ Instead of doing a review with suggestions for basically all lines (all of them rather small improvements and additions), I figured it probably makes more sense to simply commit the changes to your fork. See https://github.com/picocms/picocms.github.io/pull/54/files/079df54faa06581dc5543dad91bc75af88cd8c7d..c4d26bebf9803bdf2f10e009060733225a6adc1d for a diff. Please simply change anything that needs further improvement. That's enough for today. I didn't write anything new, just tried to improve the things you already wrote. My next step will be updating Pico's |
|
Looks pretty good. I'll still want to run through and edit it sometime, as I noticed a few minor typos and grammatical issues as I went. Nothing major though. Not gonna lie, I was a little upset when I first saw this hit my inbox, as it looked like you just deleted half the document at first glance. Git does not handle rearranging file contents well. 😂 Been a little behind on everything lately, as you might have noticed. I'm going to hopefully try to catch up with things a little over the next few days though. 😅 |
Yeah, it does not 🙈 Besides the list of changes it's basically all yours. Looking forward to your further improvements 👍
Dito 😄 I had no time the last two weekends either, but will likely have some next weekend. My next step will be to include the changes from |
I did figure that out eventually! It was just the face-value shock of seeing all the paragraphs in red. 😨 I was like "What did you do to my document?!" 😱 After a few lines, I realized I was actually just seeing the upgrade instructions moving up. 🤦🏻♀️ Anyway, I've just been doing things at my own pace. Taking it a little slow since I've been feeling a little overwhelmed in general lately. Not about Pico stuff, just in general. It's definitely been impacting my motivation though. So, just let me know if we hit "crunch time" with this, and I'll make a point to stop dragging my feet and get some work done. 😉😅 |
|
Here we go 👍 I've just updated the upgrade docs to include everything I could think of and also updated Pico's sample contents to include the latest changes. I also synced these with the website. The only thing missing from my side is some testing. I likely won't do this today, but next weekend - and then publish the first beta. So, if you find some time it would be great if you can look through all this ❤️ |
|
@mayamcdougall I just recently got an email from Justin (unfortunately I don't know his GitHub nick) that he's trying to get in touch with you about the docs rewrite, he wants to contribute. In the course of this conversation I noticed that I don't have a recent email address of yours. Can you send me your current email address via [email protected] please? Thanks! 👍 |
|
Sorry for the unintentional radio silence. 😓 I’ve been super overwhelmed for this last month and I don’t even know where the time has gone. On top of already falling behind on things… my wife brought home a puppy. 😳 So… um… yeah. He’s a good boy… but he’s very much been forcefully rearranging both my sleep schedule and my productivity time. 😅 At the moment, I’m still trying to get back into my productivity mindset. But, you know how it goes… the longer you put something down for, or put something off for, the harder it becomes to get started. 😫 I could probably say more here, but I’ve had this comment half-typed in a text editor for a week now, and I really just need to post it to let you know where I’ve been at. 😅 |
|
Haha, no worries, as you see I didn't really stick to my time schedule either 😅 😉 Take your time 👍 Since Justin is waiting for a reply, I just wanna point you to this:
|
|
*email notification noises* 🔔 |
|
Um... well... that happened. 👀 I reorganized my personal repo today, and that made GitHub automatically close this. 🤦🏻♀️ I get why it happened, since that branch has changed, but I wasn't even notified about it closing. I got messaged about it by someone else! It just feels like there should have been a warning or something. "Hey, this repo changed, and now the PR is invalid so it's being closed." Nope, nothing. And I can't reopen it either. Any idea if it's possible to point this PR to a new branch, or is this thread just dead now? 😣 |
|
🙈 You can't change a PR's source branch, but you can restore your commits using |
|
The work isn't lost, it's just moved over to a It wasn't ever really supposed to be on My local repo was turning into a mess of conflicting changes and uncommitted files, so I had to clean things up a bit. 😅 Now I've got separate branches for You would just think that GitHub would have a way to change the PR branch without closing the whole thread. 😩 But yeah, nothing was lost, it's just on the 3.0-testing branch now. 😉 |
|
Makes sense 👍 You wanna open a new PR for the Pico 3.0 changes then? By the way, you can now also change the branch which is used to generate the live deployment. Check out "Source" below Settings -> Code and automation -> Pages of your repo. |
Done. 😉
I know, lol, that's why I'm always saying my Docs Rewrite links aren't permalinks. 😂 I switch it quite a bit. Though I do try to leave it on the Rewrite content just because I've mentioned it so often. Btw, I haven't heard back from Justin since his initial email (though, admittedly it took me almost a month to reply to him in the first place, so by comparison, he's still got some time, lol 😅). Is he someone you know personally or just someone you met elsewhere online? |
Thanks 👍
No, he just sent me an email. I'm sure he'll come back to his ideas at some point 😃 |
PhrozenByte
added
type: Invalid
and removed
info: Feedback Needed
info: Work In Progress
type: Release
labels
Please use this PR for code reviews only, for a list of major changes and for comments please refer to picocms/Pico#535