Merge pull request #674 from dkyme/dkyme-patch-1

replace strlen in readPages() with variables
picocms · Aug 14, 2023 · 0fa644e · 0fa644e
2 parents efa51f6 + a3dd0b9
commit 0fa644e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/Pico.php b/lib/Pico.php
@@ -1771,6 +1771,8 @@ protected function readPages(): void
     {
         $contentDir = $this->getConfig('content_dir');
         $contentExt = $this->getConfig('content_ext');
+        $contentDirLen = strlen($contentDir);
+        $contentExtLen = strlen($contentExt);
 
         $this->pages = [];
         $files = $this->getFiles($contentDir, $contentExt, self::SORT_NONE);
@@ -1781,7 +1783,7 @@ protected function readPages(): void
                 continue;
             }
 
-            $id = substr($file, strlen($contentDir), -strlen($contentExt));
+            $id = substr($file, $contentDirLen, -$contentExtLen);
 
             // trigger onSinglePageLoading event
             // skip inaccessible pages (e.g. drop "sub.md" if "sub/index.md" exists) by default