Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing backward compatibility problems #29

Merged
merged 3 commits into from
May 16, 2024
Merged

Fixing backward compatibility problems #29

merged 3 commits into from
May 16, 2024

Conversation

sagojez
Copy link
Contributor

@sagojez sagojez commented May 15, 2024 •
edited
Loading

This one fixes a backward incompatibility with the ConnectionType and also removes an extra step to automatically seed the database on startup.

@sagojez sagojez requested a review from moekatib as a code owner May 15, 2024 17:41
moekatib
moekatib reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@moekatib moekatib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracing::error seems out of place 🤔

@paulkr paulkr merged commit b806a77 into main May 16, 2024
4 checks passed
@paulkr paulkr deleted the fix/backward_compat_problems branch May 16, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moekatib moekatib moekatib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagojez @moekatib @paulkr