Set "All Time " range for query log datepicker based on Database ranges (luxon) #3656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PromoFaux
force-pushed
the
luxon-earliest-query
branch
3 times, most recently
from
6c1337b to
b959f44
Compare
yubiuser
reviewed
Nov 10, 2025
scripts/js/queries.js
Outdated
| // earliest_timestamp is provided in seconds since epoch | ||
| beginningOfTime = Number(data.earliest_timestamp_disk); | ||
| // Round down to nearest 5-minute segment (300 seconds) | ||
| beginningOfTime = Math.floor(beginningOfTime / 300) * 300; |
Member
There was a problem hiding this comment.
Could also work with luxon toRelative using the rounding and padding options
https://moment.github.io/luxon/api-docs/index.html#datetimetorelative
Member
|
Unrelated to your changes: the end month selector does not stick |
Member
|
I also found a strange issue: If you select a time range like "This month" and then you select "Custom Range", the selection should show the current month with all days selected until Today, but this is what I see:
|
rdwebdesign
requested changes
Nov 10, 2025
1 task
rdwebdesign
requested changes
Nov 11, 2025
Member
|
Two reported issues have been fixed upstream. I'll update the vendor files in my branch |
…PI and update date picker accordingly. We use the on-disk earliest timestamp to get the complete range. Signed-off-by: Adam Warner <[email protected]>
PromoFaux
force-pushed
the
luxon-earliest-query
branch
4 times, most recently
from
5660e60 to
e765677
Compare
… use whichever of the two timestamps is smallest (and non-zero) Signed-off-by: Adam Warner <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
PromoFaux
force-pushed
the
luxon-earliest-query
branch
from
e765677 to
ee39167
Compare
PromoFaux
changed the title
yubiuser
reviewed
Nov 20, 2025
| // We initialize them as null and populate them during page init. | ||
| let beginningOfTime = null; // seconds since epoch (set from API: info/database.earliest_timestamp) | ||
| // endOfTime should be the start of tomorrow in seconds since epoch | ||
| // We don't use 23:59:59 as the picker increments are set to 5 minutes |
Member
There was a problem hiding this comment.
Suggested change
| // We don't use 23:59:59 as the picker increments are set to 5 minutes | |
| // We don't use 23:59:59 (endOf("day")) as the picker increments are set to 5 minutes |
| if (beginningOfTime === null) { | ||
| $("#querytime").prop("disabled", true); | ||
| $("#querytime").addClass("disabled"); | ||
| $("#querytime-note").text("No data in the database"); |
Member
There was a problem hiding this comment.
Suggested change
| $("#querytime-note").text("No data in the database"); | |
| $("#querytime-note").text("ℹ️ No data in the database"); |
| endDate: luxon.DateTime.fromMillis(until * 1000), // convert to milliseconds since epoch | ||
| locale: { | ||
| format: dateformat, | ||
| firstDay: 7, |
Member
There was a problem hiding this comment.
This might be a British thing, but my week starts on Monday
Suggested change
| firstDay: 7, | |
| firstDay: 1, |
| "Last Hour": [now.minus({ hours: 1 }), now], | ||
| Today: [now.startOf("day"), maxDateDt], | ||
| Yesterday: [now.minus({ days: 1 }).startOf("day"), now.minus({ days: 1 }).endOf("day")], | ||
| "Last 7 Days": [now.minus({ days: 6 }), maxDateDt], |
Member
There was a problem hiding this comment.
Suggested change
| "Last 7 Days": [now.minus({ days: 6 }), maxDateDt], | |
| "Last 7 Days": [now.minus({ days: 6 }).startOf("day"), maxDateDt], |
| Today: [now.startOf("day"), maxDateDt], | ||
| Yesterday: [now.minus({ days: 1 }).startOf("day"), now.minus({ days: 1 }).endOf("day")], | ||
| "Last 7 Days": [now.minus({ days: 6 }), maxDateDt], | ||
| "Last 30 Days": [now.minus({ days: 29 }), maxDateDt], |
Member
There was a problem hiding this comment.
Suggested change
| "Last 30 Days": [now.minus({ days: 29 }), maxDateDt], | |
| "Last 30 Days": [now.minus({ days: 29 }).startOf("day"), maxDateDt], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Builds upon #3655 and uses the newly published
earliest_timestamp_diskto set the earliest possible date in the daterangepicker.Due to an issue in the new daterangepicker library, there is a cosmetic issue which is fixed with a locally applied patch temporarily. This can be removed if/when the vendor integrates the upstream PR Wernfried/daterangepicker#1
By submitting this pull request, I confirm the following:
git rebase)