Skip to content

Conversation

@cpeintre
Copy link

@cpeintre cpeintre commented Nov 1, 2025

Display MAC addresses and client comments in both Top Clients (total) and Top Clients (blocked only) tables on the homepage. This provides more detailed information about clients at a glance without needing to navigate to separate pages.

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Display MAC addresses and client comments in both Top Clients (total)
and Top Clients (blocked only) tables on the homepage. This provides
more detailed information about clients at a glance without needing
to navigate to separate pages.
@cpeintre cpeintre requested a review from a team as a code owner November 1, 2025 13:09
Modified updateTopClientsTable() to fetch client metadata from both
/clients and /clients/_suggestions APIs to populate MAC addresses
and comments columns. The function now:

- Fetches configured clients to get comments
- Fetches client suggestions to map IPs to MAC addresses
- Merges this metadata with top clients statistics
- Gracefully handles API failures by showing table without metadata

This ensures the new columns are populated with actual data.
@yubiuser yubiuser added Template Ignored Template absent (or not filled) Submitter Attention Required labels Nov 1, 2025
@rdwebdesign
Copy link
Member

rdwebdesign commented Nov 1, 2025

You need to fix your PR. Please check the failing tests.

Also, can you provide a screenshot of the tables including the suggested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants