Pi-hole Web v6.1 #3354
Merged
Pi-hole Web v6.1 #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move selector where appropriate Signed-off-by: XhmikosR <[email protected]>
xo doesn't understand CSS syntax so it was useless that it was checking CSS files. Also, configure autoprefixer so that its changes do not need a prettier fix after that. Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Co-authored-by: RD WebDesign <[email protected]> Signed-off-by: Dominik <[email protected]>
- set Docker versions (local/remote) to `null` if they are empty strings, undefined or null; - set other components versions to `"N/A"` if they are empty strings, undefined or null; - set branches and hashes to `null` if they are empty strings, undefined or null; Signed-off-by: RD WebDesign <[email protected]>
…#2319 for further details Signed-off-by: DL6ER <[email protected]>
Signed-off-by: Alex Whitman <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
Co-authored-by: RD WebDesign <[email protected]> Signed-off-by: Adam Warner <[email protected]>
…rview Signed-off-by: DL6ER <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
…dashboard's top lists Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…dashboard's top lists Signed-off-by: DL6ER <[email protected]>
- interfaces that do not depend on others (and have no children) are placed at the top of the treeview - interfaces that do have children get them directly assigned below them Signed-off-by: DL6ER <[email protected]>
…rver-side (where no https may be used when a reverse proxy is used) to user-side where this is more definite Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
* no need to run CodeQL on Dependabit PRs; no related files are changed there * specify permissions * enable `security-and-quality` rules instead of the default rules * ignore `vendor` folders Signed-off-by: XhmikosR <[email protected]>
Even though right now the API doesn't include any HTML code, it's a better practice to be defensive here. Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
This is set in FTL to `no-cache, no-store, must-revalidate, private, max-age=0` so this is redundant Signed-off-by: XhmikosR <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.12 to 3.28.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3.28.12...v3.28.13) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
|
I think we have enough changes to account for 6.1.0 |
Signed-off-by: XhmikosR <[email protected]>
dschaper
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v6.1 release of the Pi-hole Web interface with multiple bug fixes, improvements, and updates across the codebase. Key changes include switching API endpoints to use a configurable apiUrl, refining UI elements such as CPU load and TLS status display, and updating workflows and configurations for CodeQL and Node.js.
Reviewed Changes
Copilot reviewed 107 out of 120 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/js/gravity.js | Updated API endpoint usage and corrected related comments |
| scripts/js/footer.js | Switched API URL concatenation, updated TLS detection, CPU load display, and login detection logic |
| scripts/js/charts.js | Updated URL routing for queries |
| postcss.config.js | Added autoprefixer configuration |
| .github/workflows/test.yml | Upgraded Node.js setup action version |
| .github/workflows/codeql.yml | Upgraded CodeQL action versions and modified workflow triggers |
| .github/codeql/codeql-config.yml | Added new CodeQL configuration file |
Files not reviewed (13)
- .gitattributes: Language not supported
- gravity.lp: Language not supported
- groups-clients.lp: Language not supported
- groups-domains.lp: Language not supported
- groups-lists.lp: Language not supported
- groups.lp: Language not supported
- index.lp: Language not supported
- interfaces.lp: Language not supported
- login.lp: Language not supported
- messages.lp: Language not supported
- network.lp: Language not supported
- package.json: Language not supported
- queries.lp: Language not supported
Comments suppressed due to low confidence (2)
scripts/js/footer.js:223
- The removal of the themename parameter in the applyCheckboxRadioStyle call might cause unexpected behavior if the function still relies on this argument. Please verify that the function signature and its usage are consistent with the intended logic.
applyCheckboxRadioStyle();
scripts/js/footer.js:739
- Switching the TLS detection to rely solely on location.protocol may not correctly detect HTTPS when the application is behind a reverse proxy. Consider reviewing if additional headers or configurations are needed to accurately determine the connection encryption status.
const isTLS = location.protocol === "https:";
DL6ER
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
versionsobject by @rdwebdesign in Set default values for each property ofversionsobject #3268X-UA-Compatiblemeta tag by @XhmikosR in Remove the obsoleteX-UA-Compatiblemeta tag #3305testpr: run prefix script too by @XhmikosR intestpr: run prefix script too #3307-by @XhmikosR in Fix stray-#3318eminstead ofiandstronginstead ofbby @XhmikosR in Useeminstead ofiandstronginstead ofb#3321buttonby @XhmikosR in queries: switch to a realbutton#3339meta http-equiv="cache-control"by @XhmikosR in Removemeta http-equiv="cache-control"#3353New Contributors
Full Changelog: v6.0.2...v6.1