Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found in LCARS theme after recent changes in CSS and HTML #3327

Merged
merged 4 commits into from
Mar 16, 2025

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Mar 16, 2025

What does this PR aim to accomplish?

Fix the issues found in #3326:

  • Fix the reversed numbers
  • Fix the broken collapsed menu

How does this PR accomplish the above?

  • placing the numbers icons inside the same <span> tag used for the button text.

@rdwebdesign
Copy link
Member Author

The reversed icons were really easy to fix.
Now I need to find out what is causing the collapsed menu issue.

@rdwebdesign rdwebdesign force-pushed the fix/lcars_reversed_icons branch from ae09e37 to 44892db Compare March 16, 2025 04:34
@rdwebdesign rdwebdesign marked this pull request as ready for review March 16, 2025 04:36
@rdwebdesign rdwebdesign requested a review from a team March 16, 2025 04:37
@rdwebdesign rdwebdesign merged commit ff29670 into development Mar 16, 2025
12 checks passed
@rdwebdesign rdwebdesign deleted the fix/lcars_reversed_icons branch March 16, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants