-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] with LCARS enabled the numbers in sidebar are flip and shown in reverse order #3326
Comments
This shouldn't be happening, but I'm sure this is a regression caused by some of the many recent changes in CSS themes (and maybe also on the HTML). This seems related to the "trick" I used to position the the icon used to show the sub-items of the treeview in LCARS theme. This theme has buttons with right-aligned text and to make this work without changing the HTML code, I used Some recent change applied this rule to the wrong elements. I'm not sure how the current code looks like. I will need to check. |
Note: The reverse order (Domains: blocked first, then allowed - List: number of lists first, then number of domains) is intentional. |
This is fixed on |
I was strictly referring to numbers only. Also thank you for the quick fix!! |
Versions
Core
Version is v6.0.5-17-g3f5c009 (Latest: null)
Branch is development
Hash is 3f5c0091 (Latest: 3f5c0091)
Web
Version is v6.0.2-65-gd4a5018d (Latest: null)
Branch is development
Hash is d4a5018 (Latest: d4a5018)
FTL
Version is vDev-7a17c44 (Latest: null)
Branch is development
Hash is 7a17c44c (Latest: 7a17c44c)
Platform
Expected behavior
numbers not flipped
Actual behavior / bug
with LICARS enabled the numbers in sidebar are flip and shown in reverse order
Steps to reproduce
Steps to reproduce the behavior:
for my debugging steps i used
sudo pihole checkout master
and the numbers aren't flipped onmaster
switched back to
development
and the numbers flipped again as seen in the screenshot above.also worth noting is the numbers weren't flipped when i submitted #3303 (check the screenshot provided in that issue)
Debug Token
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: