Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] with LCARS enabled the numbers in sidebar are flip and shown in reverse order #3326

Open
mwoolweaver opened this issue Mar 16, 2025 · 5 comments
Assignees

Comments

@mwoolweaver
Copy link

mwoolweaver commented Mar 16, 2025

Versions

Core
  Version is v6.0.5-17-g3f5c009 (Latest: null)
  Branch is development
  Hash is 3f5c0091 (Latest: 3f5c0091)
Web
  Version is v6.0.2-65-gd4a5018d (Latest: null)
  Branch is development
  Hash is d4a5018 (Latest: d4a5018)
FTL
  Version is vDev-7a17c44 (Latest: null)
  Branch is development
  Hash is 7a17c44c (Latest: 7a17c44c)

Platform

  • OS and version: 24.04.2 LTS (Noble Numbat)
  • Platform: Raspberry Pi 4 Model B Rev 1.1

Expected behavior

numbers not flipped

Actual behavior / bug

with LICARS enabled the numbers in sidebar are flip and shown in reverse order

Image

Steps to reproduce

Steps to reproduce the behavior:

  1. switch to development branch
  2. Go to https://pi.hole/admin
  3. Enable LICARS theme
  4. check side bar and see numbers are flipped

for my debugging steps i used sudo pihole checkout master and the numbers aren't flipped on master

switched back to development and the numbers flipped again as seen in the screenshot above.

also worth noting is the numbers weren't flipped when i submitted #3303 (check the screenshot provided in that issue)

Debug Token

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@rdwebdesign rdwebdesign changed the title [minor] with LICARS enabled the numbers in sidebar are flip and shown in reverse order [minor] with LCARS enabled the numbers in sidebar are flip and shown in reverse order Mar 16, 2025
@rdwebdesign
Copy link
Member

rdwebdesign commented Mar 16, 2025

This shouldn't be happening, but I'm sure this is a regression caused by some of the many recent changes in CSS themes (and maybe also on the HTML).

This seems related to the "trick" I used to position the the icon used to show the sub-items of the treeview in LCARS theme.

Image

This theme has buttons with right-aligned text and to make this work without changing the HTML code, I used scale(-1) to invert some icons.

Some recent change applied this rule to the wrong elements. I'm not sure how the current code looks like. I will need to check.

@rdwebdesign rdwebdesign self-assigned this Mar 16, 2025
@rdwebdesign
Copy link
Member

rdwebdesign commented Mar 16, 2025

There are other things broken in LCARS.

Clicking on the button to collapse the menu Image, the menu doesn't show icons and the button text is completely misplaced or absent.

This is a comparison showing master (correct) vs develpoment (broken):

Image

@rdwebdesign
Copy link
Member

rdwebdesign commented Mar 16, 2025

with LCARS enabled the numbers in sidebar are flip and shown in reverse order

Note:

The reverse order (Domains: blocked first, then allowed - List: number of lists first, then number of domains) is intentional.
This is the same order used by LCARS before the recent changes.

@rdwebdesign
Copy link
Member

This is fixed on development branch.

@mwoolweaver
Copy link
Author

The reverse order (Domains: blocked first, then allowed - List: number of lists first, then number of domains)

I was strictly referring to numbers only.

Also thank you for the quick fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants