Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVPN: typo fix #1184

Merged
merged 2 commits into from
Mar 3, 2025
Merged

OpenVPN: typo fix #1184

merged 2 commits into from
Mar 3, 2025

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Mar 2, 2025

Fixes #1005.

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: XhmikosR <[email protected]>

Signed-off-by: XhmikosR <[email protected]>
@XhmikosR XhmikosR marked this pull request as ready for review March 2, 2025 07:13
Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit fd193f0
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67c603c42291cd00080a95b8
😎 Deploy Preview https://deploy-preview-1184--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash down the two commits

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Mar 3, 2025 via email

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Squash and merge' was disabled. Never noticed that such an option existed.

@yubiuser yubiuser merged commit 99eb9ba into pi-hole:master Mar 3, 2025
8 checks passed
@XhmikosR XhmikosR deleted the patch-1 branch March 4, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in OpenVPN deprecation notice
2 participants