Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Domain to IP in API_URL #450

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

darkexplosiveqwx
Copy link

@darkexplosiveqwx darkexplosiveqwx commented Mar 18, 2025

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Fixes #448

How does this PR accomplish the above?:

This changes API_URL to be https://192.160.0.1:443/api/ instead of https://pi.hole:443/api/ by taking the server specified with --server.
This fixes the client not using the pihole its PADDing to a DNS since webserver.domain doesnt need to be resolved anymore.
Additionally this will lower the outgoing DNS requests for webserver.domain, why would we need to resolve that if we already know the ip of the server.
When specifying a hostname with --server, it was already checked in the beginning that the hostname is avalible via the systems DNS. (with cmdResult="$(dig +short chaos txt domain.api.ftl @"${SERVER}" 2>&1; echo $?)")

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Sorry, something went wrong.

Signed-off-by: darkexplosiveqwx <[email protected]>
Signed-off-by: darkexplosiveqwx <[email protected]>
@darkexplosiveqwx darkexplosiveqwx changed the title Domain to ip Change Domain to IP in API_URL Mar 18, 2025
Signed-off-by: darkexplosiveqwx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant