fix dhcp display in padd tiny

[christianboyle]

What does this PR aim to accomplish?:

This PR fixes a regression to PADDtiny introduced in v4.0.0.

The addition of the DHCP status display caused line wrapping, which caused a blank line to appear, which cut off the header information display.

How does this PR accomplish the above?:

1. Maintains the correct number of lines for the tiny display (53x20)
2. Shows both IPv6 and DHCP status information
3. Keeps the formatting consistent with other display modes

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• [x ] I have read the above and my PR is ready for review. Check this box to confirm

[yubiuser]

Thanks for your PR. Please base on and target development brach.

---

You reverted the new additions by removing ${dhcp_check_box}" "Rng" "${dhcp_range}. Maybe you can keep them and play a bit with the paddings to fit everything in one line?

[christianboyle]

@yubiuser In case you're curious why I didn't just add the variables back, there is a display issue where the opening checkbox bracket gets the color from the Enabled Disabled display:

If there's a better way to handle that, let me know.

[rdwebdesign]

there is a display issue where the opening checkbox bracket gets the color from the Enabled Disabled display:

I see the blank line, but I can't replicate this color issue:

Also, your screenshot on the PR description is not showing this color error when using the original code.

[rdwebdesign]

@yubiuser

I think the only issue is the excessive padding near the end of the line: %-36s${reset_text}${clear_line}\n.

Why do we need it there?
I think this was a mistake... I don't think this line will ever fit in "tiny".

[christianboyle]

@yubiuser @rdwebdesign

Hey, sorry for the confusion. In my original commit I had a typo where ${dhcp_range_heatmap} became ${dhcp_heatmap} which threw things into a bad state.

It seems like my latest fix has things rendering like you see in this screenshot, which is probably closer to correct than what we had been seeing with the [-] indicator, due to us testing with the wrong variable.

Edit: Although, I'm now seeing DNSSEC: Disabled with Disabled in blue in @rdwebdesign's screenshot. So I guess I'm not sure what's intended at this point.

[yubiuser]

I think the big padding was needed because the range can be something like 198.167.345.123 - 198.167.345.200 which is alone 33 characters

[rdwebdesign]

The issue is:
in the current master code, after the "Rng" string, we have only 33 columns available (including the space):

 DHCP:     [-]   Rng N/A
SYSTEM ==============================================
                    1234567890          1234567890 
                              1234567890          123

The maximum padding should be 32 to avoid the blank line.

Your range example will overflow anyway:

Note: the range you posted as example is invalid. 345... really?!? (I just noticed after posting the images) 😅 😂

You can remove the spaces around the hyphen in the range string... or you can simply remove the "Rng" string and add the IPs right after the box:

[christianboyle]

Ok, here's where things stand:

1. [Disabled] corrected to use checkbox [-] with blue hyphen, which is the expected display
   -- The issue was that in the "tiny" display format, we're using dhcp_range_heatmap to color the DHCP status text instead of using the dhcp_check_box variable.

2. Rng: removed and @rdwebdesign's sample IP range tested with hardcoded value
   -- Reduced the spacing after the checkbox from 5 spaces to 2 spaces
   -- Increased the width allocation for the DHCP range from 10 to 45 characters

Edit: If someone could test with DHCP enabled, that would be good; I'm wondering why we don't see the [✓], like we expect, in @rdwebdesign's screenshot with IP range.

Edit 2: I see our errant empty line is back, fixing now.

[christianboyle]

Ok, things should be all good now.

[christianboyle]

One last adjustment; making this N/A the only yellow item on the screen was annoying.

This change handles it conditionally:

• N/A is blue, which is consistent with the checkbox hyphen style for Disabled state
• IP Range continues to be yellow, unchanged from the existing style in master

[yubiuser]

Could you squash them all down please. Then this can be merged.

Code has been simplified a lot - requested change not necessary anymore