Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] OTP push support #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] OTP push support #122

wants to merge 3 commits into from

Conversation

slycoder
Copy link
Contributor

@slycoder slycoder commented Jun 5, 2018

Support push for OL protect as an MFA. Note this is a work in progress. Due to some bugs in the OL api, this is not ready for prime time yet.

Description

For some devices, rather than entering in the code you should be able to respond to a push notification. This just requires changing the way verify factor is called a tiny bit.

Related Issue

#109

Motivation and Context

Responding to pushes to authorize is sometimes more ergonomic =).

How Has This Been Tested?

Not yet tested.

@slycoder
Copy link
Contributor Author

slycoder commented Jun 5, 2018

Also thanks to @danmerl for getting the ball rolling on this PR.

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #122 into master will decrease coverage by 1.95%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #122      +/-   ##
=========================================
- Coverage   78.35%   76.4%   -1.96%     
=========================================
  Files           6       6              
  Lines         328     339      +11     
=========================================
+ Hits          257     259       +2     
- Misses         71      80       +9
Impacted Files Coverage Δ
onelogin_aws_cli/__init__.py 66.05% <30.76%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74aab3b...c05aea3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants