Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Testcase ontology #81

Merged
merged 11 commits into from
Mar 15, 2021
Merged

Remove Testcase ontology #81

merged 11 commits into from
Mar 15, 2021

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Mar 7, 2021

We use some RDF properties in the testcase: namespace to tie the JSON-LD file together (since keys in JSON-LD files without an associated RDF property will not be read as RDF). However, these properties don't actually need to be defined anywhere, certainly not in the Phyloref Testcase Ontology that we created ages ago as a repository for these terms. This PR removes the Phyloref Testcase Ontology from the OWL imports in generated phyloreferences.

It also removes many of the uses of the testcase: namespace, including the no-longer-used taxonomic unit matching system. Three of these terms could be replaced with CDAO terms, so I've replaced these in this PR:

As of #78 (comment), there are five testcase: terms remaining in Phyx.js:

  • Needed to tie the generated OWL/JSON-LD file together:
    • testcase:has_phylogeny, in the form <ontology> testcase:has_phylogeny <phylogeny>.
    • testcase:has_phyloreference, in the form <ontology> testcase:has_phyloreference <phyloref>.
    • testcase:has_component_class, in the form <phyloref> testcase:has_component_class <component class>.
  • Optional; only needed if we want to keep the verbatim specifiers in the generated OWL/JSON-LD file:
    • testcase:internal_specifier, in the form <phyloref> testcase:internal_specifier <internal specifier>.
    • testcase:external_specifier, in the form <phyloref> testcase:external_specifier <external specifier>.

We could figure out what to do with these terms in this PR, or leave that for a separate PR.

@gaurav gaurav changed the base branch from master to add-specimen-and-taxon-circumscription March 7, 2021 21:58
Base automatically changed from add-specimen-and-taxon-circumscription to master March 9, 2021 16:24
@gaurav gaurav marked this pull request as ready for review March 10, 2021 02:53
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment. I'm also wondering whether CDAO doesn't simply need to be fixed so as not to assert an edge as the domain of has_Node.

src/wrappers/PhylogenyWrapper.js Outdated Show resolved Hide resolved
@gaurav
Copy link
Member Author

gaurav commented Mar 12, 2021

I'm also wondering whether CDAO doesn't simply need to be fixed so as not to assert an edge as the domain of has_Node.

I don't think so, since has_Node (and its subproperties, has_Parent_Node and has_Child_Node) are designed specifically for use with edges, rather than the node-based has_Parent/has_Child. But I've opened an issue to discuss this on CDAO: evoinfo/cdao#17.

@gaurav gaurav requested a review from hlapp March 12, 2021 02:20
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@gaurav gaurav merged commit db1a3b1 into master Mar 15, 2021
@gaurav gaurav deleted the remove-testcase-ontology branch March 15, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants