-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Testcase ontology #81
Conversation
This was useful back when Phyx.js matched taxonomic units, but now that is done by the OWL logical expressions.
078e0d4
to
4701e1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment. I'm also wondering whether CDAO doesn't simply need to be fixed so as not to assert an edge as the domain of has_Node
.
I don't think so, since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
We use some RDF properties in the
testcase:
namespace to tie the JSON-LD file together (since keys in JSON-LD files without an associated RDF property will not be read as RDF). However, these properties don't actually need to be defined anywhere, certainly not in the Phyloref Testcase Ontology that we created ages ago as a repository for these terms. This PR removes the Phyloref Testcase Ontology from the OWL imports in generated phyloreferences.It also removes many of the uses of the
testcase:
namespace, including the no-longer-used taxonomic unit matching system. Three of these terms could be replaced with CDAO terms, so I've replaced these in this PR:testcase:PhyloreferenceTestPhylogeny
corresponds to aCDAO:RootedTree
.testcase:has_root_node
corresponds toCDAO:has_Root
.testcase:has_node
corresponds toCDAO:has_Element
(confusingly, it does NOT correspond toCDAO:has_Node
, whose domain is Edges, not Trees).As of #78 (comment), there are five
testcase:
terms remaining in Phyx.js:testcase:has_phylogeny
, in the form<ontology> testcase:has_phylogeny <phylogeny>
.testcase:has_phyloreference
, in the form<ontology> testcase:has_phyloreference <phyloref>
.testcase:has_component_class
, in the form<phyloref> testcase:has_component_class <component class>
.testcase:internal_specifier
, in the form<phyloref> testcase:internal_specifier <internal specifier>
.testcase:external_specifier
, in the form<phyloref> testcase:external_specifier <external specifier>
.We could figure out what to do with these terms in this PR, or leave that for a separate PR.