Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Phyx files #43

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Add support for Phyx files #43

merged 3 commits into from
Apr 7, 2021

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Apr 6, 2021

OTR previously only supported loading JSON-LD representations of phyloreferences. This PR adds support for loading Phyx files instead, and then uses phyx.js to convert the Phyx file into its JSON-LD representation. It also changes the example file to a Phyx file instead of a JSON-LD file. Note that this is still a Phyx 0.2.0 file -- we'll need to update to a Phyx 1.0.0 file in a future PR (#44).

Closes #39. Should be merged after PR #42.

@gaurav gaurav marked this pull request as ready for review April 6, 2021 17:14
@gaurav gaurav requested a review from hlapp April 6, 2021 17:17
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Base automatically changed from upgrade-npm-packages to master April 7, 2021 16:25
@gaurav gaurav merged commit 10e8795 into master Apr 7, 2021
@gaurav gaurav deleted the add-support-for-phyx-files branch April 7, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Phyx files
2 participants