Allow argc = 0.

This is allowed according to the C++ standard, so don’t invoke undefined behavior when converting argv[0] to a string.
phst · Dec 23, 2021 · 7157c29 · 7157c29
1 parent 780d8d8
commit 7157c29
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/elisp/binary.template b/elisp/binary.template
@@ -17,12 +17,14 @@
 #include "elisp/binary.h"
 
 int PHST_RULES_ELISP_MAIN(int argc, phst_rules_elisp::NativeChar** argv) {
-  std::vector<phst_rules_elisp::NativeString> args = {
+  using phst_rules_elisp::NativeString;
+  using phst_rules_elisp::RunBinary;
+  std::vector<NativeString> args = {
     [[args]],
     PHST_RULES_ELISP_NATIVE_LITERAL("--")
   };
   args.insert(args.end(), argv, argv + argc);
-  return phst_rules_elisp::RunBinary(argv[0], args);
+  return RunBinary(argc == 0 ? NativeString() : argv[0], args);
 }
 
 // Local Variables:

diff --git a/emacs/driver.template b/emacs/driver.template
@@ -17,12 +17,14 @@
 #include "elisp/emacs.h"
 
 int PHST_RULES_ELISP_MAIN(int argc, phst_rules_elisp::NativeChar** argv) {
-  std::vector<phst_rules_elisp::NativeString> args = {
+  using phst_rules_elisp::NativeString;
+  using phst_rules_elisp::RunEmacs;
+  std::vector<NativeString> args = {
     [[args]],
     PHST_RULES_ELISP_NATIVE_LITERAL("--")
   };
   args.insert(args.end(), argv, argv + argc);
-  return phst_rules_elisp::RunEmacs(argv[0], args);
+  return RunEmacs(argc == 0 ? NativeString() : argv[0], args);
 }
 
 // Local Variables: