-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override npc spawn function #16
Draft
mike8699
wants to merge
1
commit into
main
Choose a base branch
from
custom-npc-spawn-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike8699
force-pushed
the
custom-npc-spawn-function
branch
from
February 6, 2022 04:43
dffadcc
to
621f7dd
Compare
mike8699
changed the base branch from
main
to
spawn-any-item-as-freestanding-key
February 6, 2022 04:43
mike8699
changed the base branch from
spawn-any-item-as-freestanding-key
to
main
February 6, 2022 04:43
mike8699
force-pushed
the
custom-npc-spawn-function
branch
from
February 6, 2022 04:44
621f7dd
to
1e61631
Compare
mike8699
force-pushed
the
custom-npc-spawn-function
branch
from
March 21, 2022 03:01
1e61631
to
79c2fd8
Compare
Should be good for now as long as PR 24 doesn't render this obsolete. |
It shouldn't render it obsolete, but it's not really needed for now. I believe I wrote this to help with rendering the correct NSBMD model for freestanding/dropped items, but decided to postpone that for later. I'll just leave this in draft state for now. |
mike8699
force-pushed
the
custom-npc-spawn-function
branch
from
April 10, 2022 05:41
79c2fd8
to
5f3fa9a
Compare
This doesn't change how the function works; essentially it just relocates it somewhere else so we have the ability to make changes/extend it.
mike8699
force-pushed
the
custom-npc-spawn-function
branch
from
April 10, 2022 06:15
5f3fa9a
to
efe792b
Compare
mike8699
added
the
base-rom-patch
Related to the base rom patch (i.e. the assembly hacks applied to the ROM prior to randomization)
label
Apr 12, 2022
mike8699
force-pushed
the
main
branch
2 times, most recently
from
October 26, 2022 01:58
4cd13e5
to
4fc0cda
Compare
mike8699
force-pushed
the
main
branch
12 times, most recently
from
October 1, 2023 18:48
a7c655e
to
7230878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
base-rom-patch
Related to the base rom patch (i.e. the assembly hacks applied to the ROM prior to randomization)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change how the function works; essentially it just relocates it somewhere else so we have the ability to make changes/extend it.