Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override npc spawn function #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mike8699
Copy link
Contributor

@mike8699 mike8699 commented Feb 6, 2022

This doesn't change how the function works; essentially it just relocates it somewhere else so we have the ability to make changes/extend it.

@mike8699 mike8699 changed the base branch from main to spawn-any-item-as-freestanding-key February 6, 2022 04:43
@mike8699 mike8699 changed the base branch from spawn-any-item-as-freestanding-key to main February 6, 2022 04:43
@mike8699 mike8699 marked this pull request as draft March 4, 2022 04:14
@lunarsoap5
Copy link
Contributor

Should be good for now as long as PR 24 doesn't render this obsolete.

@mike8699
Copy link
Contributor Author

Should be good for now as long as PR 24 doesn't render this obsolete.

It shouldn't render it obsolete, but it's not really needed for now. I believe I wrote this to help with rendering the correct NSBMD model for freestanding/dropped items, but decided to postpone that for later. I'll just leave this in draft state for now.

This doesn't change how the function works; essentially it just relocates it somewhere else so we have the ability to make changes/extend it.
@mike8699 mike8699 changed the base branch from main to optimize-code-size April 10, 2022 06:15
Base automatically changed from optimize-code-size to main April 10, 2022 07:42
@mike8699 mike8699 added the base-rom-patch Related to the base rom patch (i.e. the assembly hacks applied to the ROM prior to randomization) label Apr 12, 2022
mike8699 added a commit that referenced this pull request May 3, 2022
@mike8699 mike8699 force-pushed the main branch 12 times, most recently from a7c655e to 7230878 Compare October 1, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base-rom-patch Related to the base rom patch (i.e. the assembly hacks applied to the ROM prior to randomization)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants