chore(docs): Adjust job_template_locale properties #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlumMichael
force-pushed
the
STRINGS-1270
branch
from
a6bbfa5 to
cc1c860
Compare
Comment on lines
+3282
to
+3284
| "type": "string", | ||
| "nullable": true, | ||
| "description": "The ID of the job template locale. Will return `null` if the related `job_template` is global." |
There was a problem hiding this comment.
Issue: If I'm not mistaken, we need to change the locale_preview schema so it can also just show the fields name and code. That would be in line 1433. But maybe it's better to create a new schema because the field id won't be showing at all.
There was a problem hiding this comment.
I agree, I'd vote for a separate schema
BlumMichael
force-pushed
the
STRINGS-1270
branch
from
2cf8e4a to
646b5c7
Compare
jablan
reviewed
Feb 17, 2025
| @@ -5,10 +5,12 @@ job_template_locale: | |||
| properties: | |||
| id: | |||
| type: string | |||
| nullable: true | |||
There was a problem hiding this comment.
hm is this also nullable, this is not a locale id, but the id of the "relationship" resource?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust job_template_locale api endpoint-docs, since
idis now anullablefield.See: