Resolve substr based on configured PHP version #4061
Conversation
VincentLanglet
force-pushed
the
substr
branch
2 times, most recently
from
6c212e9 to
364fbed
Compare
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| use PHPStan\Testing\TypeInferenceTestCase; | |||
|
|
|||
| class LooseConstComparisonPhp7Test extends TypeInferenceTestCase | |||
| class NodeScopeResolverPhp7Test extends TypeInferenceTestCase | |||
There was a problem hiding this comment.
Since the neon file is only
parameters:
phpVersion: 70400 # PHP 7.4
we could use those TestCase for all the configured-phpVersion-related tests instead of creating a TestCase every time.
|
This pull request has been marked as ready for review. |
| @@ -0,0 +1,9 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I think you can add the lint comment which makes the file beeing analyzed in the proper version
There was a problem hiding this comment.
The lint comment is for the runtime PHP version no ? (Like it's done for a lot of NodeScopeResolverPHPTest).
Here I want to allow Analysing this file on both PHP 7 and PHP 8, but telling PHPStan to consider he's in PHP 7.
|
btw: since phpunit got upgraded on the PHPStan 2.x branch, we need to be careful to send PRs to PHPStan 1.12.x only when easy mergabe into 2.x (attributes got added etc) |
Only change is this attribute I dunno if it will even create a conflict but if ondrej ask, I can target 2.1.x instead :) |
Closes phpstan/phpstan#13129