Keep traversing type when we can contain lowercase/upercase strings #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/getRecommendedLevelByType
branch
from
71d2836 to
36406a9
Compare
staabm
reviewed
Jan 21, 2025
| { | ||
| /** @var array{numeric-string} $b */ | ||
| $b = $a; | ||
| } |
There was a problem hiding this comment.
do we need more tests for different variants of this problem?
like
Suggested change
| } | |
| } | |
| /** | |
| * @param array{numeric-string&uppercase-string&lowercase-string} $a | |
| */ | |
| public function sayUpper(array $a): void | |
| { | |
| /** @var array{uppercase-string} $b */ | |
| $b = $a; | |
| } | |
| /** | |
| * @param array{numeric-string&uppercase-string&lowercase-string} $a | |
| */ | |
| public function sayLower(array $a): void | |
| { | |
| /** @var array{lowercase-string} $b */ | |
| $b = $a; | |
| } |
There was a problem hiding this comment.
maybe also variants with non-empty-string, non-falsey-string?
There was a problem hiding this comment.
I don't think so since it's not related to numeric-string directly.
The issue was because it was a ConstantArray with a lowercase-string or upercase-string inside.
Because of the early return $type we didn't process the content of the array.
There was a problem hiding this comment.
But I added a test for the callable case
ad97094
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12457