Improve count() narrowing of constant arrays

[herndlm]

Generalizes the already existing solution (wow, this is way more complicated than I thought!) and uses it outside of union types as well. I kind of had to make the "isNormalCount" determination a bit more dry, which unfortunately made the diff worse..

I did do a performance comparison with hyperfine running make phpstan and didn't notice any changes, but my system is not the best.

Closes phpstan/phpstan#12190
Closes phpstan/phpstan#3631

[herndlm]

I know, I changed that narrow* method to return Type instead of SpecifiesTypes. Maybe I'll change this back again tomorrow.

[herndlm]

I know, I changed that narrow* method to return Type instead of SpecifiesTypes. Maybe I'll change this back again tomorrow.

adapted. looks better now IMO. The master plan is to move more common things for both count() == xx and count > xx specification into the now renamed specifyTypesForCountFuncCall(). Would also be great if turnListIntoConstantArray() goes away completely or is only used internally once... But for here this is more than enough IMO.

@staabm what do you think about this?

[staabm]

what do you think about this?

this PR looks great, thanks for cleaning up after me :)

[herndlm]

Should stuff like this be based on 1.12.x or latest dev branch? I sometimes have issues deciding 😅

[ondrejmirtes]

Big changes to TypeSpecifier I prefer on 2.1.x, to avoid conflicts.

[herndlm]

Thx, makes sense. And good call, there was a conflict.. Rebased this and also other of my PRs on 2.1.x and dealt with conflicts 😊

[herndlm]

I think this is ready, only that first issue bot response is confusing me slightly: https://github.com/phpstan/phpstan-src/actions/runs/12635127480. but at the same time it looks like those errors are already there now (https://phpstan.org/r/3cb22712-7994-4b1c-9946-3946083ddb27) or am I missing something?

UPDATE: ah wait, it's line 109 of PHP 7.1 - 7.4 which seems to be loosing some generic info I think. I'll check again then..

[herndlm]

ok done, this was even simplified further, is now behaving as I expect it to and should be save :)

[phpstan-bot]

This pull request has been marked as ready for review.