Fix bug in array-shape subtraction #3308
Conversation
| $keepSeparate = true; | ||
| foreach ($this->valueTypes as $valueType) { | ||
| if ($valueType->isConstantValue()->yes()) { | ||
| $keepSeparate = false; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
we somehow need to identify which constant arrays we can/want to keep separte (in our case tagged unions), without running into "is always false" comparison false positives like
list<array{string, 1|2|3|4|5|6|7}> and list<array{string, 1|2|3|4|5|6|7, int}> will always evaluate to false
I think my approach is wrong, but I have no better idea atm
There was a problem hiding this comment.
Any change to isSuperTypeOf logic needs tests in TypeCombinatorTest::dataUnion and dataIntersect. So please express there what you're trying to achieve, only when reviewing that I can decide if it makes sense or not.
There was a problem hiding this comment.
I could not figure out a dataUnion and dataIntersect test.
but what made sense to me was a test like
subtract array{mixed} from array{mixed, string|null, mixed}|array{mixed} should lead to array{mixed, string|null, mixed}
| // should be array{0: mixed, 1: string|null} | ||
| assertType('array{mixed, mixed}', $row); |
There was a problem hiding this comment.
I think thats another bug
| $keepSeparate = true; | ||
| foreach ($this->valueTypes as $valueType) { | ||
| if ($valueType->isConstantValue()->yes()) { | ||
| $keepSeparate = false; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Any change to isSuperTypeOf logic needs tests in TypeCombinatorTest::dataUnion and dataIntersect. So please express there what you're trying to achieve, only when reviewing that I can decide if it makes sense or not.
|
Can this PR be finished please, many of our CI pipelines are still failing because of this. Thank you in advance! |
|
@mvorisek will continue after vacation. Please make sure to sponsor my efforts. Thanks in advance |
|
@ondrejmirtes, Ondřej, I do not want you to talk to me like this. If some of my communication ruin your patience, please always share the reasons with me to be able to understand your attitude better. I hope we can talk about these feelings openly. Thank you. |
closes phpstan/phpstan#11488