[WIP] Refactory & Enhancement #96

feryardiant · 2017-04-28T18:40:27Z

Perubahan

Tidak lagi menggunakan folder www sebagai document root & menambahkan folder asset untuk menampung semua file CSS, JS, Fonts & Images.
Mengubah codebase, detail perubahan bisa dilihat di tiap commit message.
Penggunaan file .env untuk setting dasar. Meminimalisir terjadinya konflik ketika ada perubahan atau penambahan key di file app/settings.php.

Perbaikan

Memperbaiki mailer (terkait SMTP connect() failed after member registration #94), disini mailer akan kita ubah dari sebelumnya menggunakan postmark (SMTP) ke sparkpost (ReST API) dimana kelebihan utama dari penggunaan ReST API adalah proses pengiriman email dibebankan ke provider, bukan server production. Selain itu sparkpost juga menawarkan fitur mail marketing secara gratis jadi jika nantinya kita butuh untuk bulk email dapat di-handle oleh sparkpost dengan lebih efisien.
Optimasi tampilan pada mobile (terkait Style Issue #80)

Penambahan (Experimental)

Optimasi static asset (CSS, JS & Image) dengan tools. Opsi sementara adalah gulp atau webpack.
Menggunakan heroku sebagai staging sekaligus meng-enable fitur review, memungkinkan tiap pull request (nantinya) akan ada online demo yang di generate otomatis oleh heroku.
Menyediakan testing, walaupun tidak semuanya akan di test tapi setidaknya kita punya fitur ini untuk memastikan berjalan semestinya.

* develop: Fix notfound routes: - Throw NotFoundException if profile not found, - Experimentaly add custom json request Fix missing request method Fix missing route BC contained updates: - Rename JS files based on its functionalities and make membership.js as central API, - Update routes on Account Skills and Portfolios, make it more convenience to interact with its API, - Add new 'formInputMethod' method in view extension, help method override, - Some updates according changes above. Change CSS and JS indentation under www folder to 2 spaces Fix ajax city on register page, as per phpindonesia#65 menghilangkan validasi email pada nama perusahaan ajax select city Fix error

* develop: Add request json filter

* develop: - Fix docblocks - Refactor Slim\Container injection in class __construct to ContainerAware trait - Concat all middlewares into single class and simplify its usage

Signed-off-by: Fery Wardiyanto <[email protected]>

* develop: Update www/.htaccess Update dependencies

Signed-off-by: Fery Wardiyanto <[email protected]>

… namespace Signed-off-by: Fery Wardiyanto <[email protected]>

Signed-off-by: Fery Wardiyanto <[email protected]>

close phpindonesia#92 Signed-off-by: Fery Wardiyanto <[email protected]>

Signed-off-by: Fery Wardiyanto <[email protected]>

okaprinarjaya · 2017-04-29T02:26:43Z

Reviewing

feryardiant · 2017-04-29T14:30:33Z

Thanks om @okaprinarjaya, ada ide apa aja yang perlu dibenahi lagi?

okaprinarjaya · 2017-04-29T15:37:39Z

Saya matur suwuunn bangett kepada om @feryardiant , sudah meluangkan waktunya.
apakah ada ide lagi? saya pikir cukup, item-item di section Penambahan (Experimental) adalah ide-ide yg cukup besar dan harus digiring supaya terimplementasi.

Silahkan di-merge om, saya gak berani merge, karena om Fery yg lebih tau apakah PR ini sudah complete atau belom. Atau apakah ada yg butuh ditambahkan lg saya sementara belum tahu.

feryardiant · 2017-04-29T18:33:15Z

Sami-sami om @okaprinarjaya, kebetulan mumpung saya ada waktu luang weekend ini jadi saya optimalkan untuk ngurusin repo ini (yang sudah saya terlantarkan cukup lama, hiks 😢).

Sementara PR ini masih berstatus WIP & masih ada TODO yang belum selesai tidak akan saya merge dulu sampai saya rasa sudah benar-benar siap. 🥂

herloct · 2017-05-01T02:18:20Z

Menurut ane yg paling penting itu testing-nya dulu oom. Mungkin tepatnya functional atau acceptance testing-nya kali ya, kalo unit atau integration test kayanya rada mubazir kalo liat codebase yg sekarang.

Kalo boleh saran juga, sebaiknya bertahap, sedikit2 langsung di-pr n merge, dibanding nunggu banyak n langsung merge sekaligus.
Misal pr pertama ubah struktur direktori, selesai langsung merge.
Trus pr buat functional/acceptance testing, selesai langsung merge.

herloct · 2017-05-01T05:50:20Z

Memperbaiki mailer (terkait #94)...

Yg ini ga langsung di-merge aja oom?

feryardiant · 2017-05-01T10:38:16Z

Saya perlu memastikan semua todo disini sudah saya selesaikan dulu & maaf kalo mungkin akan sedikit makan waktu.

Saya juga masih ada kendala di salah satu penambahan (eksperimental) fitur yaitu penggunaan Heroku Review App yaitu heroku/heroku-buildpack-php#227

Signed-off-by: Fery Wardiyanto <[email protected]>

- [x] Validates all request thru request object, - [x] Validation rules defined on model class, - [x] Add new transaction method on Database class to handle transaction easily, - [x] Some additional updates due to changes above Signed-off-by: Fery Wardiyanto <[email protected]>

Signed-off-by: Fery Wardiyanto <[email protected]>

feryardiant · 2017-05-04T00:04:31Z

Mailer done thru Sparkpost.

Tinggal bershi-bersih yang lain.. 🎉 🎉 🥂

Signed-off-by: Fery Wardiyanto <[email protected]>

feryardiant added 19 commits February 6, 2016 19:17

Merge branch 'develop'

b42c81c

* develop: Add request json filter

Merge branch 'develop'

9166b31

* develop: - Fix docblocks - Refactor Slim\Container injection in class __construct to ContainerAware trait - Concat all middlewares into single class and simplify its usage

Update dependencies

8e8ec29

Signed-off-by: Fery Wardiyanto <[email protected]>

Merge branch 'develop'

e8f65af

* develop: Update www/.htaccess Update dependencies

Update dependencies

087b677

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix container docblock

f2ce96a

Signed-off-by: Fery Wardiyanto <[email protected]>

[skip ci] fix merge conflict

75ca754

Signed-off-by: Fery Wardiyanto <[email protected]>

Init refactory

c82a334

Signed-off-by: Fery Wardiyanto <[email protected]>

Refactor Database namespace

d05b7d3

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix docblock

bcca41f

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix some issue due to previous commit

005ceb8

Signed-off-by: Fery Wardiyanto <[email protected]>

Update homepage url to new phpindonesia.id

ca3aa53

Signed-off-by: Fery Wardiyanto <[email protected]>

Update readme.md

759bad6

Signed-off-by: Fery Wardiyanto <[email protected]>

Bring back old directory structures with some additional changes

1d7332b

Signed-off-by: Fery Wardiyanto <[email protected]>

Update .editorconfig due to latest directory changes

40fd5f3

Signed-off-by: Fery Wardiyanto <[email protected]>

Create .env.example

8ff736b

Signed-off-by: Fery Wardiyanto <[email protected]>

Update readme & remove setting.php.disabled

801a4e0

Signed-off-by: Fery Wardiyanto <[email protected]>

[refactor] Middleware & Controllers classes now under Memberhsip\Http…

a0c69c7

… namespace Signed-off-by: Fery Wardiyanto <[email protected]>

feryardiant added discussion enhancement labels Apr 28, 2017

feryardiant self-assigned this Apr 28, 2017

feryardiant requested review from okaprinarjaya and peterjkambey April 28, 2017 18:40

feryardiant added 6 commits April 29, 2017 01:43

Remove Libraries namespace and move all classes to root

732e414

Signed-off-by: Fery Wardiyanto <[email protected]>

Register errorHanler first

bb2ca4e

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix something due to 732e414

2cc85e5

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix controller classes due to a0c69c7

b50b097

Signed-off-by: Fery Wardiyanto <[email protected]>

Add app.json for heroku reviews

41125ca

Signed-off-by: Fery Wardiyanto <[email protected]>

Add lisence.md

cc187e2

close phpindonesia#92 Signed-off-by: Fery Wardiyanto <[email protected]>

feryardiant added 8 commits April 29, 2017 03:06

Add DB_DRIVER envvar

a9c4c04

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix some settings

a7328e6

Signed-off-by: Fery Wardiyanto <[email protected]>

Patch docblock

82f83e3

Signed-off-by: Fery Wardiyanto <[email protected]>

Simplify usage of Models classes

9c113ce

Signed-off-by: Fery Wardiyanto <[email protected]>

Extend Slim\Http\Response and inject view engine

0174eda

Signed-off-by: Fery Wardiyanto <[email protected]>

Install spackpost client

1cb24d9

Signed-off-by: Fery Wardiyanto <[email protected]>

Change mailer container to mail

a43de20

Signed-off-by: Fery Wardiyanto <[email protected]>

Update mailer

9783162

Signed-off-by: Fery Wardiyanto <[email protected]>

okaprinarjaya approved these changes Apr 29, 2017

View reviewed changes

feryardiant added 8 commits May 3, 2017 22:58

Patch mailer container

6a723e6

Signed-off-by: Fery Wardiyanto <[email protected]>

Add ActionResolver class to make easier resolve controller methods

819a7f8

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix validation issue

4450cf7

Signed-off-by: Fery Wardiyanto <[email protected]>

Use httpclient directly to send mail instead of SparkPost client

5bb7684

Signed-off-by: Fery Wardiyanto <[email protected]>

Fix sending mail via sparkpost 🎉

b7af819

Signed-off-by: Fery Wardiyanto <[email protected]>

Remove sparkpost/sparkpost

9483be4

Signed-off-by: Fery Wardiyanto <[email protected]>

Add phpunit for testing

7997383

Signed-off-by: Fery Wardiyanto <[email protected]>

feryardiant added 4 commits May 4, 2017 07:36

Patch user activation

c6e3bc9

Signed-off-by: Fery Wardiyanto <[email protected]>

Add withRedirectRoute method

8ca9805

Signed-off-by: Fery Wardiyanto <[email protected]>

Patch validation request

e68fee2

Signed-off-by: Fery Wardiyanto <[email protected]>

Cleanup unused params

f1cef7d

Signed-off-by: Fery Wardiyanto <[email protected]>

feryardiant mentioned this pull request Jun 6, 2017

SMTP connect() failed after member registration #94

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Refactory & Enhancement #96

[WIP] Refactory & Enhancement #96

feryardiant commented Apr 28, 2017 •

edited

Loading

okaprinarjaya commented Apr 29, 2017

feryardiant commented Apr 29, 2017

okaprinarjaya commented Apr 29, 2017

feryardiant commented Apr 29, 2017

herloct commented May 1, 2017

herloct commented May 1, 2017

feryardiant commented May 1, 2017

feryardiant commented May 4, 2017

[WIP] Refactory & Enhancement #96

Are you sure you want to change the base?

[WIP] Refactory & Enhancement #96

Conversation

feryardiant commented Apr 28, 2017 • edited Loading

Perubahan

Perbaikan

Penambahan (Experimental)

okaprinarjaya commented Apr 29, 2017

feryardiant commented Apr 29, 2017

okaprinarjaya commented Apr 29, 2017

feryardiant commented Apr 29, 2017

herloct commented May 1, 2017

herloct commented May 1, 2017

feryardiant commented May 1, 2017

feryardiant commented May 4, 2017

feryardiant commented Apr 28, 2017 •

edited

Loading