Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README.md #469

Merged
merged 2 commits into from
Mar 25, 2025
Merged

fix README.md #469

merged 2 commits into from
Mar 25, 2025

Conversation

raffaelecarelle
Copy link
Contributor

with string 'AsController' does not work

with string 'AsController' does not work
@micheleorselli
Copy link
Member

for the sake of consistency with the rest of the documentation I would keep the parameters as a string, maybe we should specify the fqcn?

Replaced the short class name with its fully qualified counterpart in the README code example for clarity. This ensures accurate context and prevents potential namespace resolution issues.
@raffaelecarelle
Copy link
Contributor Author

Hi @micheleorselli I specified it as fqcn

Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@micheleorselli micheleorselli merged commit bf4f2c7 into phparkitect:main Mar 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants