Remove X/Twitter link from homepage social media section#1879
Open
castillo-n wants to merge 1 commit intophp:masterfrom
Open
Remove X/Twitter link from homepage social media section#1879castillo-n wants to merge 1 commit intophp:masterfrom
castillo-n wants to merge 1 commit intophp:masterfrom
Conversation
The PHP project appears to have moved away from X (see ThePHPF/thephp.foundation#194). Removes the link from the homepage sidebar while keeping Mastodon and LinkedIn. Closes php#1877
castillo-n
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the X/Twitter link from the homepage social media sidebar.
Mastodon and LinkedIn links stay as they are.
I noticed the
icon-x-twitterclass is still defined in the fontelloCSS files but no longer referenced anywhere after this change — might
be worth cleaning that up separately.
I also considered pulling the social links into a config array so they
could be toggled on/off by setting the URL to empty — that way if an
account gets abandoned in the future, it's just a value change instead
of editing HTML. Ended up keeping this PR minimal but figured I'd
mention it in case that's something worth doing down the line.
Closes #1877