Create UserNoteService class #1662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Preview for commit e1444a4 can be found at https://web-php-pr-1662.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit e1444a4 is at https://web-php-regression-report-pr-1662.preview.thephp.foundation |
src/UserNotes/UserNoteService.php
Outdated
| $repo = strtolower($LANG); | ||
| // Link target to add a note to the current manual page, | ||
| // and it's extended form with a [+] image | ||
| $addnotelink = '/manual/add-note.php?sect=' . $filename . |
src/UserNotes/UserNoteService.php
Outdated
| // and it's extended form with a [+] image | ||
| $addnotelink = '/manual/add-note.php?sect=' . $filename . | ||
| '&repo=' . $repo . | ||
| '&redirect=' . $_SERVER['BASE_HREF']; |
Member
Author
There was a problem hiding this comment.
What are these reviews?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves user note related functionality to a dedicated class. This helps with code organization. Only a very minimal refactoring was done to help with PR reviewing; it was mostly copy-paste.
See #710