Skip to content

Exempt adding Type and Value Errors from BC break policy #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 5 commits into from
Apr 5, 2026
Merged

Exempt adding Type and Value Errors from BC break policy #27

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8750751
Exempt adding Type and Value Errors from BC break policy
Girgias Feb 17, 2026
61a4088
Reorganize + error messages
Girgias Feb 25, 2026
58b9e55
Typo fixes
Girgias Mar 18, 2026
b84b61d
fix ci?
Girgias Mar 18, 2026
50ab953
maybe this time
Girgias Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions release-process.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ The following are **not considered** BC breaks:
choosing new names, but SHOULD NOT pick significantly worse names purely to
reduce conflict risk.

- Adding TypeError and ValueError exceptions to validate inputs to functions
and methods. These are not classified as BC breaks because not adding them
allows incorrect code to run and thus leads to hard to debug code.
Copy link
Copy Markdown
Member

@ramsey ramsey Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add hyphens to turn the adjective phrase into a compound word, increasing readability.

Suggested change
allows incorrect code to run and thus leads to hard to debug code.
allows incorrect code to run and thus leads to hard-to-debug code.

Copy link
Copy Markdown
Member

@iluuu1994 iluuu1994 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not classified as BC breaks because not adding them allows incorrect code to run and thus leads to hard to debug code.

IMO this wording is not great. Maybe:

Missing validation for undocumented or clearly unintended argument values are considered PHP core bugs with unpredictable or incorrect behavior. As such, adding the desired validation is not considered BC breaking.


- Changing the wording of diagnostic, error, or exception messages.

- Behavior changes in undefined or undocumented edge cases MAY be allowed if
well justified. However, care SHOULD be taken to minimize disruption.

Expand Down