Allow distribution of musl + glibc binaries#545
Merged
Conversation
Search for binaries with the anylibc suffix as a fallback candidate. This allows shipping binaries that work both on glibc and musl without copying the same binary with two separate names.
asgrim
approved these changes
Mar 16, 2026
Contributor
|
Thanks @cataphract :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search for binaries with the
anylibcsuffix as a fallback candidate (on Linux only).This allows shipping binaries that work both on glibc and musl without copying the same binary with two separate names.
The second commit fixes assertion failures when not running a linux/glibc (I think a better long-term solution would be to extend
TargetPlatformto also take the libc flavor.Fixes #544
PR submitter checklist