ext/soap: to_xml_array() heap use-after-free with illegal iterator keys. - #22896
Open
devnexen wants to merge 2 commits into
Open
ext/soap: to_xml_array() heap use-after-free with illegal iterator keys.#22896devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
Fix php#22895 The return value of array_set_zval_key() was ignored, so when the key is not a legal array offset, e.g. MultipleIterator::key() returning an array, it threw and took no reference. The unconditional zval_ptr_dtor() then dropped the iterator's only reference to the borrowed value and the following Z_TRY_ADDREF_P() read freed memory. Let array_set_zval_key() own its reference the way spl_iterator_to_array_apply() does, and stop iterating on failure.
NickSdot
reviewed
Jul 28, 2026
| try { | ||
| $client->__soapCall('audit', [new SoapVar($iterator, SOAP_ENC_ARRAY)]); | ||
| } catch (TypeError $e) { | ||
| echo $e->getMessage(), PHP_EOL; |
Contributor
There was a problem hiding this comment.
Suggested change
| echo $e->getMessage(), PHP_EOL; | |
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22895
The return value of array_set_zval_key() was ignored, so when the key is not a legal array offset, e.g. MultipleIterator::key() returning an array, it threw and took no reference. The unconditional zval_ptr_dtor() then dropped the iterator's only reference to the borrowed value and the following Z_TRY_ADDREF_P() read freed memory.
Let array_set_zval_key() own its reference the way spl_iterator_to_array_apply() does, and stop iterating on failure.