Skip to content

zlib: fix test skipif sections #22099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndossche wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+4 −29
Open

zlib: fix test skipif sections #22099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ext/zlib/tests/bug55544-win.phpt
View file
Open in desktop
Binary file not shown.
18 changes: 0 additions & 18 deletions ext/zlib/tests/func.inc
View file
Open in desktop

This file was deleted.

7 changes: 2 additions & 5 deletions ext/zlib/tests/gzencode_variation2-win32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@ if( substr(PHP_OS, 0, 3) != "WIN" ) {
die("skip.. only for Windows");
}



include 'func.inc';
if (version_compare(get_zlib_version(), "1.2.11") < 0) {
die("skip - at least zlib 1.2.11 required, got " . get_zlib_version());
if (version_compare(ZLIB_VERSION, "1.2.11") < 0) {
die("skip - at least zlib 1.2.11 required, got " . ZLIB_VERSION);
}
?>
--FILE--
Expand Down
4 changes: 1 addition & 3 deletions ext/zlib/tests/gzgetc_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ Test function gzgetc() by calling it with its expected arguments zlib 1.2.5
zlib
--SKIPIF--
<?php

include 'func.inc';
if (version_compare(get_zlib_version(), '1.2.5') > 0) {
if (version_compare(ZLIB_VERSION, '1.2.5') > 0) {
die('skip - only for zlib <= 1.2.5');
}
?>
Expand Down
4 changes: 1 addition & 3 deletions ext/zlib/tests/gzgetc_basic_1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ Test function gzgetc() by calling it with its expected arguments zlib 1.2.7
zlib
--SKIPIF--
<?php

include 'func.inc';
if (version_compare(get_zlib_version(), '1.2.7') < 0) {
if (version_compare(ZLIB_VERSION, '1.2.7') < 0) {
die('skip - only for zlib >= 1.2.7');
}
?>
Expand Down
Loading