-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Arginfo: add and use known strings for attributes #19075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Split out from the PropertyInfo class so that known strings can also be used for attributes in a follow-up commit.
This is the first part of my follow-up to #18780 dealing with reducing the work of registering attributes on constants (and other things) - here, if a string is known the known string is used for attribute name and values, and
Yes I agree. Originally posted by @nielsdos in #18780 (comment) |
return $result; | ||
} | ||
$include = self::PHP_80_KNOWN; | ||
switch ($minPhp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because gen_stub supports running on PHP 7.4, I have a todo to update that eventually
No description provided.