Skip to content

Arginfo: add and use known strings for attributes #19075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Arginfo: add and use known strings for attributes #19075

wants to merge 3 commits into from
+252 −560

Conversation

DanielEScherzer
Copy link
Member

No description provided.

@DanielEScherzer
Copy link
Member Author

This is the first part of my follow-up to #18780 dealing with reducing the work of registering attributes on constants (and other things) - here, if a string is known the known string is used for attribute name and values, and 8.0, 8.1, 8.2, 8.3, 8.4, and 8.5 are all added as known strings.

the same strings are allocated twice

It should probably be safe to just intern them all. They are always allocated on start-up, so the memory will be used either way. Interning should just reduce it, no?

Yes I agree.
If you pinky promise that you're gonna look at it before 8.5's release I'll allow it.

Originally posted by @nielsdos in #18780 (comment)

kamil-tekiela
kamil-tekiela reviewed Jul 8, 2025
View reviewed changes
build/gen_stub.php
return $result;
}
$include = self::PHP_80_KNOWN;
switch ($minPhp) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because gen_stub supports running on PHP 7.4, I have a todo to update that eventually

@TimWolla TimWolla removed their request for review July 9, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela left review comments

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

@NattyNarwhal NattyNarwhal Awaiting requested review from NattyNarwhal NattyNarwhal is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
ABI break Category: Build System Category: Engine Extension: curl Extension: date Extension: dom Extension: enchant Extension: filter Extension: hash Extension: intl Extension: libxml Extension: mysqli Extension: odbc Extension: openssl Extension: pgsql Extension: random Extension: reflection Extension: shmop Extension: soap Extension: spl Extension: standard Extension: xml Extension: zip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielEScherzer @kamil-tekiela