ext/session: Various refactorings #19041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You broke something hard, and it seems related to the ini quantity parsing. I don't think quantity parsing makes a lot of sense for those settings |
Girgias
force-pushed
the
session-refactor-07-2025
branch
from
20eda53 to
d13ef59
Compare
nielsdos
approved these changes
Jul 6, 2025
ext/session/session.c
Outdated
| date_fmt = php_format_date("D, d M Y H:i:s \\G\\M\\T", sizeof("D, d M Y H:i:s \\G\\M\\T")-1, t, 0); | ||
| smart_str_appends(&ncookie, COOKIE_EXPIRES); | ||
| date_fmt = php_format_date(ZEND_STRL("D, d M Y H:i:s \\G\\M\\T"), t, false); | ||
| smart_str_appendl(&ncookie, ZEND_STRL(COOKIE_EXPIRES)); |
There was a problem hiding this comment.
For cases like these, I prefer the original code. The strlen() call will almost certainly be evaluated at compile time.
There was a problem hiding this comment.
Right, I forgot that this is inlined. I was expecting the need for a _literal suffix API.
To make it easier for IDEs to understand what is going on
This is unnecessary now that the session name is a zend_string
Girgias
force-pushed
the
session-refactor-07-2025
branch
from
f656530 to
82c1e8c
Compare
nielsdos
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed one by one