Pdo sqlite refactor#18804
Conversation
There was a problem hiding this comment.
Strictly speaking this requires an upgrading entry.
There was a problem hiding this comment.
Similarly, your newly added constants need upgrading entries
There was a problem hiding this comment.
This uses the old-style constant instead of the new one you introduced. Shouldn't both be tested?
There was a problem hiding this comment.
These are old-style constants instead of the subclass specific ones. Do we still want to add new ones to here instead of only continuing to evolve the subclasses?
There was a problem hiding this comment.
Yes, we should only add new ones on the subclasses. Reminds me that I wanted to slate the overloaded PDO instances with methods for deprecation in 8.5
There was a problem hiding this comment.
This is a class constant, not a global constant.
devnexen
force-pushed
the
pdo_sqlite_refactor
branch
from
afcf17f to
7f80836
Compare
allow to check if a statement is still running before reusage. close phpGH-18804
devnexen
force-pushed
the
pdo_sqlite_refactor
branch
from
7f80836 to
55a9b03
Compare
3 participants
No description provided.