Fix GH-17330: SNMP::setSecurity segfaults when object had been closed. #17337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Girgias
requested changes
Jan 3, 2025
ext/snmp/snmp.c
Outdated
| @@ -87,6 +87,13 @@ typedef struct snmp_session php_snmp_session; | |||
| } \ | |||
| } | |||
|
|
|||
| #define PHP_SNMP_FETCH_OBJECT \ | |||
There was a problem hiding this comment.
I would prefer a macro function rather than assume the name of the variable
There was a problem hiding this comment.
I'm also not a big fan of these obscure macros, and given that we need it only once for now, I would suggest to inline it in ::setSecurity().
There was a problem hiding this comment.
in fact I was waiting feedback on the close() comment.
No, e.g. getErr* do not need at all the session part. see also the close comment, we could do it there but can be a BC. |
cmb69
reviewed
Jan 5, 2025
…sed. checking when the workflow needs to deal with an existing SNMP session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having new macro when the workflow needs to deal with an existing SNMP session.