Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite http gh16810 test to not be online #17314

Open
wants to merge 1 commit into
base: PHP-8.3
Choose a base branch
from

Conversation

bukka
Copy link
Member

@bukka bukka commented Jan 1, 2025

This changes the test to not access external resources but use php cli server

@bukka bukka changed the base branch from master to PHP-8.3 January 1, 2025 10:22
@cmb69
Copy link
Member

cmb69 commented Jan 1, 2025

I'm very much in favor of avoiding online test, so thank you!

However, we still have about 30 online tests (master branch), so it might make sense to actually run these in some of the nightly CI jobs (might be a bit flaky, but better than not noticing issues).

@cmb69 cmb69 mentioned this pull request Jan 1, 2025
@bukka bukka force-pushed the stream_test_http_timeout branch from 499988a to 807422b Compare January 1, 2025 13:57
@bukka
Copy link
Member Author

bukka commented Jan 1, 2025

However, we still have about 30 online tests (master branch), so it might make sense to actually run these in some of the nightly CI jobs (might be a bit flaky, but better than not noticing issues).

We already discussed it in #8390 and I'm still not really in favour of this as they might be flaky and the flaky tests take time to check and are quite annoying. I have been trying to reduce the flakiness of the test suite in the last few months (e.g. the ephemeral port conversion) so I will try to put more effort into the online conversion. Think some of them are pretty easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants