Skip to content

fix race: remove metrics shutdown assignments #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henderkes wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −36
Open

fix race: remove metrics shutdown assignments #2452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,70 +303,34 @@ func (m *PrometheusMetrics) Shutdown() {

if m.totalWorkers != nil {
m.registry.Unregister(m.totalWorkers)
m.totalWorkers = nil
}

if m.busyWorkers != nil {
m.registry.Unregister(m.busyWorkers)
m.busyWorkers = nil
}

if m.workerRequestTime != nil {
m.registry.Unregister(m.workerRequestTime)
m.workerRequestTime = nil
}

if m.workerRequestCount != nil {
m.registry.Unregister(m.workerRequestCount)
m.workerRequestCount = nil
}

if m.workerCrashes != nil {
m.registry.Unregister(m.workerCrashes)
m.workerCrashes = nil
}

if m.workerRestarts != nil {
m.registry.Unregister(m.workerRestarts)
m.workerRestarts = nil
}

if m.readyWorkers != nil {
m.registry.Unregister(m.readyWorkers)
m.readyWorkers = nil
}

if m.workerQueueDepth != nil {
m.registry.Unregister(m.workerQueueDepth)
m.workerQueueDepth = nil
}

m.totalThreads = prometheus.NewCounter(prometheus.CounterOpts{
Name: "frankenphp_total_threads",
Help: "Total number of PHP threads",
})
m.busyThreads = prometheus.NewGauge(prometheus.GaugeOpts{
Name: "frankenphp_busy_threads",
Help: "Number of busy PHP threads",
})
m.queueDepth = prometheus.NewGauge(prometheus.GaugeOpts{
Name: "frankenphp_queue_depth",
Help: "Number of regular queued requests",
})

if err := m.registry.Register(m.totalThreads); err != nil &&
!errors.As(err, &prometheus.AlreadyRegisteredError{}) {
panic(err)
}

if err := m.registry.Register(m.busyThreads); err != nil &&
!errors.As(err, &prometheus.AlreadyRegisteredError{}) {
panic(err)
}

if err := m.registry.Register(m.queueDepth); err != nil &&
!errors.As(err, &prometheus.AlreadyRegisteredError{}) {
panic(err)
}
}

Expand Down
Loading