Skip to content

Closing old issues before convertion. #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfsb merged 1 commit into from
Jul 24, 2026
Merged

Closing old issues before convertion. #5704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions bookinfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
<!-- $Revision$ -->

<info xmlns="http://docbook.org/ns/docbook" xml:id="bookinfo">
&frontpage.authors;
<pubdate><?dbtimestamp format="Y-m-d"?></pubdate>
&frontpage.editors;

<legalnotice xml:id="copyright" xmlns:xlink="http://www.w3.org/1999/xlink">
<info><title>Copyright</title></info>
Expand All @@ -20,7 +18,7 @@
</legalnotice>

</info>

<!-- Keep this comment at the end of the file
Local variables:
mode: sgml
Expand Down
5 changes: 4 additions & 1 deletion entities/entities-remove.ent → entities/entities.remove.ent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ empty <entities/> element at the end of file, only updating the revtag.
xmlns:xlink = "http://www.w3.org/1999/xlink"
translate = "remove">

<!-- Erased in 2026-06, long time empty -->
<!-- Erased in 2024-08, doc-ru -->

@jordikroon jordikroon Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this file will get longer should we have a convention for adding lines? This should also make it easier for other contributors to phase out entities.

Perhaps something like:
<!-- Erased in <date>, ref: #3633, todo: doc-<lang>, doc-<lang> -->

<!-- Erased in <date>, ref: */bookinfo.xml, todo: doc-<lang> -->

@alfsb alfsb Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These conventions are good, and please add them to new entries.

But as this file may grow and be rarely trimmed, or have its comments updated, I think the only real way this file will be reduced is with bruteforce testing its contents against all languages, from time to time.

I was working in an "exact" userland XML assembler that could be used instead, but as it is constantly sidestepped, and my time in docs grows thin, I can only think in the bruteforce alternative for the future, where exact or updated comments may have low impact in the end.

<entity name="url.pecl.windows.releases">https://downloads.php.net/~windows/pecl/releases/</entity>

<!-- Erased in 2026-06, */bookinfo.xml -->
<entity name="frontpage.authors"/>
<entity name="frontpage.editors"/>

Expand Down