Update ReturnTypeWillChange intro for clarity#5614
Merged
Conversation
I know I'm revisiting this topic so soon, but the clarity of the current phrasing leaves a lot to be desired. What if we structure and present the page the way this PR suggests?
mmalferov
changed the title
ReturnTypeWillChange intro for clarity
lacatoire
approved these changes
Jun 22, 2026
Comment on lines
+22
to
+24
| Return type compatibility checks for internal class extensions remain in a soft mode | ||
| until a future PHP version enforces strict checking. | ||
| At that point, mismatches will cause a fatal error instead of a deprecation notice. |
Member
There was a problem hiding this comment.
It's not very clear what the soft mode is. I assume it means that a deprecation is thrown instead of the fatal error, but that's what the paragraph above says. So is this paragraph entirely redundant?
Member
Author
There was a problem hiding this comment.
You're right, the paragraph looks overloaded, but at the same time, we must warn the reader that in a future version of PHP, the signature compatibility check will become strict. I have fixed the "lame" paragraph. Please check if everything is in order now
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
kamil-tekiela
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know I'm revisiting this topic so soon, but the clarity of the current phrasing leaves a lot to be desired. What if we structure and present the page the way this PR suggests?