-
Notifications
You must be signed in to change notification settings - Fork 830
Add a Docker Compose setup for building and serving PHP documentation locally #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
afilina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this workflow a lot. Merci!
I followed the instructions for default and fr on both Linux and PowerShell. Everything behaves as expected. I left some usability and other suggestions in the review comments.
Future improvement ideas (I can open issues once this is merged, and we can have discussions about each item at that time):
- Ask whether the user wants to clone missing dependencies.
- Remove the previous docker-based workflow.
409431b to
59500e1
Compare
afilina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the suggestions. Just the directory check that doesn't seem to behave as expected. See details in the comment.
| if [ ! -d "$DIR" ]; then | ||
| echo "❌ Missing required directory: $DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to hit this line even when I had no directories. It's checking them after the volumes are mounted, so there's always a folder, just empty.
I always get "✅ All prerequisites found." and then it crashes later.
Description
This PR adds a simple Docker Compose workflow to build and preview the PHP manual locally.
It provides a lightweight, cross-platform alternative to the existing make setup and works on Linux, macOS, and Windows (including PowerShell).
The goal is to make contributing to the documentation easier for new and existing contributors by removing installation steps and dependency issues.
Highlights
Technical notes
Does not modify the existing make build process this is an optional, self-contained alternative.
Impact
This setup should lower the barrier to entry for contributors and make it easier to test translations and improvements locally, without manual setup.