-
Notifications
You must be signed in to change notification settings - Fork 811
add a warning for callback and array with less than 2 items #4777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add a warning for callback and array with less than 2 items #4777
Conversation
bd73101
to
8239500
Compare
The callback is not called if the input has less than 2 items, | ||
an error (e.g. accessing an invalid key of an array) or an exception | ||
will not be reported, unless you test it with 2 items or more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion to split it up in 2 sentences, and a small correction (error->warning):
The callback is not called if the input has less than 2 items, | |
an error (e.g. accessing an invalid key of an array) or an exception | |
will not be reported, unless you test it with 2 items or more. | |
The callback is not called if the input has less than 2 items. | |
A warning (e.g. accessing an invalid key of an array) or an exception | |
will not be reported, unless you test it with 2 items or more. |
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to explicitly explain that an error will go unnoticed, see the example here:
Or this one: https://3v4l.org/k0bHmC#vnull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The reason I suggested warning is because invalid array keys normally don't cause errors, so the example is a bit weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, it's a warning: https://3v4l.org/SuJRd#vnull
It also trigger a deprecation, that is also silenced if the array has only one element (previous example).
I'll have to find something more problematic than using an invalid key because a warning is not a big deal. The example should mention an unrecoverable error.
Fixes #4760
usort
doesn't call the callback if the array has only one element? #4760I can't test it right now because of an issue withgit
:git
when setting up a local development environment doc-base#247Here is the result: