Namespaces: note that enums are affected #4739
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompted by a note on the manual page
TimWolla
requested changes
Jun 22, 2025
Comment on lines
+94
to
+95
| types of code are affected by namespaces: classes (including abstracts and traits), interfaces, enums (since PHP 8.1), | ||
| functions and constants. |
There was a problem hiding this comment.
Suggested change
| types of code are affected by namespaces: classes (including abstracts and traits), interfaces, enums (since PHP 8.1), | |
| functions and constants. | |
| types of code are affected by namespaces: classes (including abstract classes, traits and enums), interfaces, | |
| functions and constants. |
The version indication implied to me what enums were there before 8.1, but could only be used in namespaces with 8.1. I think leaving out the version here is just fine, since when you don't have enums, clearly they can't be in a namespace.
Also, either both traits and enums should be mentioned separately, or they both should be considered a subset of classes. No strong feeling either way. Enums are more similar to classes than traits are, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by a note on the manual page