Skip to content

#[\Override]: document restriction on __construct() #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2025
Merged

#[\Override]: document restriction on __construct() #4738

merged 3 commits into from
Jun 22, 2025
+5 −0

Conversation

DanielEScherzer
Copy link
Member

Prompted by a note on the manual page

@DanielEScherzer
#[\Override]: document restriction on __construct()
7572f13 
Prompted by a note on the manual page
@DanielEScherzer DanielEScherzer requested a review from TimWolla June 22, 2025 07:24
@DanielEScherzer
Copy link
Member Author

DanielEScherzer commented Jun 22, 2025 •
edited
Loading

This was part of the details on https://wiki.php.net/rfc/marking_overriden_methods but not noted in the docs page
See https://www.php.net/manual/en/class.override.php#130361

TimWolla
TimWolla reviewed Jun 22, 2025
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particularly strong feelings on the exact wording, but I'd like to see an explanation for the restriction. Feel free to merge after adding something.

@DanielEScherzer DanielEScherzer merged commit 7c125c7 into php:master Jun 22, 2025
2 checks passed
@DanielEScherzer DanielEScherzer deleted the no-constructor-override branch June 22, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielEScherzer @TimWolla