feat: drop twig 2 #513
Open
feat: drop twig 2 #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimler
force-pushed
the
feature/drop-twig-2
branch
3 times, most recently
from
ceb1dbc to
9aff264
Compare
composer.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| "php-translation/symfony-storage": "^2.1", | |||
| "php-translation/extractor": "^2.0", | |||
| "nyholm/nsa": "^1.1", | |||
| "twig/twig": "^2.14.4 || ^3.3", | |||
| "twig/twig": "^3.12", | |||
There was a problem hiding this comment.
We just dropped v2, I think it would be cool to keep the min available version of v3 for a while, WDYT? Or do we use something new that is available since 3.12?
There was a problem hiding this comment.
Seems that 3.12 mostly adds a lot of deprecations in preparation of 4.x: https://github.com/twigphp/Twig/blob/3.x/CHANGELOG#L71
gimler
force-pushed
the
feature/drop-twig-2
branch
from
75ecb0b to
9aff264
Compare
gimler
force-pushed
the
feature/drop-twig-2
branch
from
9aff264 to
604ecd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.