Fixing bug in the filterId() method, releasing 2.0.5.

php-tmdb · Mar 26, 2015 · 4816554 · 4816554
1 parent d2c9d69
commit 4816554
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/Tmdb/Client.php b/lib/Tmdb/Client.php
@@ -31,7 +31,7 @@ class Client
     use ApiMethodsTrait;
 
     /** Client Version */
-    const VERSION  = '2.0.4';
+    const VERSION  = '2.0.5';
 
     /** Base API URI */
     const TMDB_URI = 'api.themoviedb.org/3/';

diff --git a/lib/Tmdb/Model/Common/GenericCollection.php b/lib/Tmdb/Model/Common/GenericCollection.php
@@ -317,6 +317,10 @@ public function offsetUnset($offset)
      */
     public function filterId($id)
     {
+        if (1 === count($this->data)) {
+            return array_shift($this->data);
+        }
+
         $result = $this->filter(
             function ($key, $value) use ($id) {
                 if ($value->getId() == $id) {
@@ -325,11 +329,11 @@ function ($key, $value) use ($id) {
             }
         );
 
-        if ($result && 1 === count($result)) {
-            return array_shift($this->data);
+        if (!count($result)) {
+            return null;
         }
 
-        return null;
+        return array_shift($result->getAll());
     }
 
     /**