Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for php < 8.1, drop support for symfony < 5.4 (WIP) #243

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

Chris53897
Copy link
Contributor

#242

Just a quick view and open for disussion what to do next.
Needs rebasing after the other 2 PRs are merged.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • [] Documentation pull request created (if not simply a bugfix)

To Do

  • to Discuss

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

the failing tests (apart from the stream_for issue) are probably also about missing mocking that is now detected because of strict typing of 3rd party libraries. do you look into those?

.github/workflows/static.yml Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
drop support for symfony < 5.4,
drop support for symfony < 5.4,
.gitignore Outdated Show resolved Hide resolved
drop support for symfony < 5.4,
drop support for symfony < 5.4,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants