Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add testrun for symfony 7 #237

Merged
merged 4 commits into from
Jan 23, 2024
Merged

chore: add testrun for symfony 7 #237

merged 4 commits into from
Jan 23, 2024

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Jan 21, 2024

Please see #232 (comment)

Support for Symfony 7 is added in "phpspec/phpspec" 7.5.0
https://github.com/phpspec/phpspec/releases/tag/7.5.0

@dbu
Copy link
Contributor

dbu commented Jan 22, 2024

something is not working with those "LTS" builds - https://github.com/php-http/client-common/actions/runs/7600541313/job/20722422472?pr=237 is the one that says symfony 7, but it installs symfony 3 things 😱

we should probably set up flex with shivammatur like they do here doctrine/DoctrineBundle@42f5834 and make sure the major version is enforced.

@dbu
Copy link
Contributor

dbu commented Jan 22, 2024

the problem with the current setup: we install flex at the same time as updating the dependencies, so flex is not yet present and does not enforce versions.

@Chris53897
Copy link
Contributor Author

@dbu
I think composer global was the missing part. But maybe you are right too.
Because i did remove more parts, because i think they are obsolete.
Please have a look if i did it correct.

I changed Symfony LTS according to the real LTS.
https://symfony.com/releases

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, global is a solution as well.

and we missed to set the SYMFONY_REQUIRE variable? thanks for cleaning this up!

@dbu dbu merged commit f61eca2 into php-http:2.x Jan 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants