feat: sync CLI with dashboard@v1.6.12#77
Open
cursor[bot] wants to merge 1 commit into
Open
Conversation
Syncs the type contract with dashboard@v1.6.12 (webhook release,
sha 9e2913d). The published dashboard-api package moves from 1.2.0 ->
1.6.12; two upstream routes have breaking body/response shape changes
that are covered here:
- spectrum/profile PATCH no longer accepts avatarUrl in its body. The
avatar URL is now applied server-side by spectrum/avatar/commit, so
the client no longer needs a follow-up PATCH after upload. Remove
the profile-update step (and its --no-update-profile flag +
recovery-command helpers) from `spectrum avatar upload`, and drop
the --avatar-url option from `spectrum profile update` — that flag
now only carries firstName / lastName. Users should use
`spectrum avatar upload` for avatar changes.
- lines GET now returns { lines, pendingRegistrations } instead of a
bare SpectrumLine[] array. Unwrap data?.lines in the list command
before casting to the local DTO.
UPSTREAM_DIFF.md gets a new "Changed Routes" section noting both
signatures. `bun run check` is green (typecheck + 36 tests + build).
Co-authored-by: citron <lcandy2@users.noreply.github.com>
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteClean, minimal, well-scoped upstream sync for v1.6.12; both changed signatures are correctly migrated and the deferred surface is called out. Marking ready and approving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
v1.6.12(sha9e2913d1dbc9c9d2cec1160cca2451bd8a6da3f9)@photon-ai/dashboard-api:1.2.0→1.6.12Unlike the last several no-op bumps in the 1.6.x series (v1.6.4–v1.6.11 were all security / infra fixes with an identical public API surface), v1.6.12 does change the public API contract. Two routes now have breaking body / response shapes; both are used by the CLI and fixed in this PR.
Routes added/removed/changed
Route list vs. the 1.2.0 bundled
.d.tsis unchanged from the previous no-op runs — the 23-added / 1-removed table inUPSTREAM_DIFF.mdstill applies. What's new in 1.6.12 are two changed signatures:PATCH api.projects.:id.spectrum.profile— body no longer acceptsavatarUrl(onlyfirstName/lastName). The avatar URL is now applied server-side byspectrum/avatar/commit, so the client no longer needs a follow-up PATCH.GET api.projects.:id.lines— response is now{ lines, pendingRegistrations }instead of a bareSpectrumLine[]array.CLI-side fixes:
src/commands/spectrum/avatar.ts: drop the post-commit profile PATCH step (and its--no-update-profileflag +buildRecoveryCommand/shellQuotehelpers) since the API no longer acceptsavatarUrlthere.src/commands/spectrum/profile.ts: remove the--avatar-urloption fromspectrum profile update; the option's hint already pointed users atspectrum avatar upload, which remains the only supported path.src/commands/spectrum/lines.ts: unwrapdata?.linesbefore casting to the localSpectrumLine[]DTO in the list command.UPSTREAM_DIFF.md: add aChanged Routessection documenting both signatures and bump the summary counters to 23 added / 1 removed / 2 changed / 33 unchanged.No new commands or DTOs; new routes from the 1.6.x delta (
webhooks,whatsapp.templates,voice.settings,slack.installations,projects.:id.members, etc.) are still deferred.Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locally (typecheck + 36 tests + build, all green)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Medium Risk
Breaking upstream API shapes affect live CLI calls to profile and lines; changes are localized to Spectrum commands with a straightforward response unwrap and removed dead paths.
Overview
Bumps
@photon-ai/dashboard-apifrom1.2.0to1.6.12and updates Spectrum CLI commands for two breaking API contract changes documented inUPSTREAM_DIFF.md.Spectrum profile / avatar:
PATCH spectrum/profileno longer acceptsavatarUrl(avatars are applied onspectrum/avatar/commit). The CLI drops--avatar-urlfromspectrum profile update, removes the post-commit profile PATCH (and--no-update-profile, recovery helpers) fromspectrum avatar upload, and directs users to upload for avatars.Lines list:
GET projects/:id/linesnow returns{ lines, pendingRegistrations }instead of a bare array;spectrum lines listreadsdata?.linesfor table/JSON output (pending registrations are not surfaced yet).Reviewed by Cursor Bugbot for commit 7ddfb1f. Bugbot is set up for automated code reviews on this repo. Configure here.