This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
✨ Allow sorting inbox notifications in ascending order #2696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, inbox notifications are always sorted in descending order, so the last notification is displayed first. The usual behaviour in messaging apps is to have the opposite order, so you can read the messages as they arrived. This PR allows you to specify which order do you want to apply to the current inbox when sending a notification.
Related Issue
#2695
Motivation and Context
We have a messaging feature in our app, and we want it to behave like other messaging apps like Telegram or WhatsApp. In those apps, the notifications are displayed in the order they arrive.
How Has This Been Tested?
I didn't find any Jasmine test about inbox notifications, so I tested it manually in:
The changes are quite small and shouldn't affect other areas of the code.
Screenshots (if appropriate):
Types of changes
Checklist: