Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

✨ Allow sorting inbox notifications in ascending order #2696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpalou
Copy link

@dpalou dpalou commented Feb 4, 2019

Description

Right now, inbox notifications are always sorted in descending order, so the last notification is displayed first. The usual behaviour in messaging apps is to have the opposite order, so you can read the messages as they arrived. This PR allows you to specify which order do you want to apply to the current inbox when sending a notification.

Related Issue

#2695

Motivation and Context

We have a messaging feature in our app, and we want it to behave like other messaging apps like Telegram or WhatsApp. In those apps, the notifications are displayed in the order they arrive.

How Has This Been Tested?

I didn't find any Jasmine test about inbox notifications, so I tested it manually in:

  • Honor 8 with Android 7.
  • Android Simulator: Pixel XL with API 27.

The changes are quite small and shouldn't affect other areas of the code.

Screenshots (if appropriate):

screenshot 2019-02-04 at 09 48 33

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant