This repository was archived by the owner on Sep 4, 2020. It is now read-only.
Issue #2266: Add compatibility with katzer/cordova-plugin-local-notifications 0.9.0-beta.3#2581
Open
merrygobyebye wants to merge 1 commit intophonegap:masterfrom
Conversation
d14be79 to
34b48c7
Compare
… it for all non-push notifications
34b48c7 to
ab1410f
Compare
|
Thanks to this patch I'm able to receive 'notification' callbacks when the app receives a push notification in foreground. With the master branch the callback is never called and the notification isn't displayed. It would be great if this fix could be integrated so we don't have to use a fork :) |
|
Do I need to install only plugin from this pull request? Or * katzer/cordova-plugin-local-notifications in this pull request is also required? It seems that, in my case, it does not fix the issue when the app is completely killed (not running in the background). |
|
Did anyone merged this PR in its own fork ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compatibility with katzer/cordova-plugin-local-notifications 0.9.0-beta.3
Description
UNUserNotificationCenterDelegateand call it for all non-push notificationsRelated Issue
#2266
Motivation and Context
This solves the problem of this plugin clobbering any previously assigned delegate to the
UNUserNotificationCenter. As @wezzle mentioned, "this is something all plugins working with the notification center should do as there can only be one delegate set on the notification center."How Has This Been Tested?
on('notification')callback is executedEnvironment:
Ionic@4.2.1
Cordova ios@4.5.5
iPhone X iOS@12.0
Screenshots (if appropriate):
N/A
Types of changes
Checklist: