Issue9 #19
Open
Issue9 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdonst
requested changes
Nov 21, 2017
| if (!flagConstraints) { | ||
| return this._supportedConstraints; | ||
| } else { | ||
| exec(successConstraints, null, 'Stream', 'getSupportedConstraints', []); |
There was a problem hiding this comment.
@maverickmishra they only thing that needs to be changes is after the exec call we'll need to:
return this._supportedConstraints;
This will return the default constraints as per the spec. Without a return statement here the function will return an undefined.
There was a problem hiding this comment.
Had missed it for mediaDevices.enumerateDevices() as well. Fixed it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch data about devices and constraints when mediaDevices is created.
Description
This change pre-fetches the data provided by the mediaDevices.enumerateDevices() and mediaDevices.getSupportedConstraints when the mediaDevices object is created
Related Issue
Issue #9
Motivation and Context
This change pre-fetches the data provided by the mediaDevices.enumerateDevices() and mediaDevices.getSupportedConstraints when the mediaDevices object is created. This ends the delay in fetching this data later on when a user requests for it.
How Has This Been Tested?
Tested with pre existing tests.
Types of changes
Checklist: